dgb: delegate naughty-propagation onto coin SSOT (byte-identity rewire) - #448
Merged
Conversation
Rewire the inline ancestor-punishment body at share_tracker.hpp:566-578 onto dgb::propagate_naughty_from_parent() from coin/naughty_propagation.hpp (landed in the SSOT slice). The SSOT encodes BOTH the +1/clamp-at-6 generation arithmetic and the oracle "parent is naughty" guard (data.py:543-549): it returns nullopt for a non-naughty parent, which is exactly the prior `parent_idx->naughty > 0` branch -- the child counter is left untouched in that case, never zeroed. Value-identical to the pre-delegation inline path: engaged <=> parent_idx->naughty > 0 value = 1 + parent_naughty, reset to 0 when > 6 No consensus value changes; this is the behavioral rewire follow-on to the fenced SSOT. dgb/ only, per-coin isolation holds. Proof: dgb_share_test 33/33, dgb_naughty_propagation_test 4/4.
frstrtr
force-pushed
the
dgb/naughty-propagation-delegate
branch
from
June 24, 2026 18:39
ae51317 to
cdde321
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Byte-identity delegation follow-on to #445. Rewires the inline naughty-propagation ancestor-punishment body in
share_tracker.hppontodgb::propagate_naughty_from_parent()(the SSOT landed in #445).Why this is value-identical
The SSOT encodes both the generation arithmetic and the oracle
parent is naughtyguard (p2pool-dgb-scrypt data.py:543-549):<=>parent_idx->naughty > 0(prior inline guard)= 1 + parent_naughty, reset to0when> 6nulloptfor a non-naughty parent => child counter left untouched (never zeroed), exactly the priorif (... naughty > 0)branchNo consensus value changes vs the pre-delegation inline path. This is the behavioral-rewire follow-on integrator flagged for separate diffing.
Scope / isolation
src/impl/dgb/share_tracker.hpponly (+1 include, body delegated).dgb/per-coin isolation holds; no shared/bitcoin_family or other-coin tree touched.Stacking
Base =
dgb/naughty-propagation-ssot(#445), where the SSOT header lives. Retarget -> master after #445 lands.Proof
dgb_share_test33/33dgb_naughty_propagation_test4/4